textual icon indicating copy to clipboard operation
textual copied to clipboard

Test everything on Windows

Open willmcgugan opened this issue 2 years ago • 5 comments

Windows tends to be the most problematic platform, but the least tested.

We should test test all the examples / documentation examples on Windows, looking for bugs and inconsistencies.

We should also test the devtools on Windows. And the live-editing.

Windows users may be nearly 50% of our audience so we should be thorough with it.

willmcgugan avatar Oct 10 '22 14:10 willmcgugan

My primary system is Windows though I've never done any sort of "official" testing, are there any guides or instructions on the types of things this entails? Happy to help if I'm able to.

dlasusa avatar Oct 23 '22 16:10 dlasusa

Hey @dlasusa, thanks. As Will says above, a great place to start would be to work through the examples and also follow the tutorial from start to end, testing stuff as you go. If anything seems wrong a heads-up here would be really appreciated.

davep avatar Oct 24 '22 05:10 davep

Gotcha. @davep Thanks! I actually started doing some of that just to learn, I totally missed that was actually part of the testing. I'll spend some time and actually make notes now for anything that pops up.

dlasusa avatar Oct 24 '22 05:10 dlasusa

Awesome, thanks. Please don't hesitate to ask anything.

davep avatar Oct 24 '22 05:10 davep

Before I get too far down the path of testing the other examples, wanted to see if this is the sort of things we're after?

Windows 10 (64bit)

Python Env: Using a virtual python environment (venv) Python 3.10.8 commonmark==0.9.1 importlib-metadata==4.13.0 nanoid==2.0.0 Pygments==2.13.0 rich==12.6.0 textual==0.2.1 zipp==3.9.0

Downloaded repo as zip, copied the examples into a folder called "samples"

Project_Dir/
    samples/
    venv/
    testing_notes.txt
    textual.log

Tests:

Windows Terminal (Powershell): python.exe .\calculator.py --> Works Windows Terminal (Command): python calculator.py --> Works Standard command prompt: python calculator.py --> Works, but has visual artifacts (see image) calc_cmd

Can move all terminals between monitors (different resolutions) - no issues

After resizing the calculator... All work, but... Windows Terminal (powershell) doesn't resize quite right, but provides a scrollbar if resize smaller. (see image) Windows Terminal (command) - works best. No noticed issues. Standard command prompt has resize artifacts (see image) calc_cmd_after_resize

Powershell Scroll bar after resize: PS_scrollbar

dlasusa avatar Oct 25 '22 02:10 dlasusa

Windows compatibility is getting better and we are more regularly testing on Windows now.

I have a feeling Windows 10 is more glitchy than Windows 11, but there likely isn't much we can do about that.

Feel free to open individual issues regarding Windows compatibility.

willmcgugan avatar Jan 17 '23 10:01 willmcgugan

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

github-actions[bot] avatar Jan 17 '23 10:01 github-actions[bot]