textual icon indicating copy to clipboard operation
textual copied to clipboard

Binary encoding of devtools packets

Open willmcgugan opened this issue 3 years ago • 1 comments

The devtools console is awesome and I use it a lot.

It will tend to slow down when there is a lot of data going through. We should use a binary protocol to avoid some additional work encoding / decoding. msgpack would be ideal for this.

Should be a simple change.

willmcgugan avatar May 13 '22 09:05 willmcgugan

I've heard of msgpack but haven't used it myself yet, however I've used CBOR quite a lot (via this Python library) and it works well too :slightly_smiling_face: Could be worth trying with both, and see what produces the most compact/efficient payload?

olivierphi avatar May 13 '22 11:05 olivierphi

https://github.com/Textualize/textual/wiki/Sorry-we-closed-your-issue

willmcgugan avatar Oct 25 '22 09:10 willmcgugan

Did we solve your problem?

Glad we could help!

github-actions[bot] avatar Oct 25 '22 09:10 github-actions[bot]