textual icon indicating copy to clipboard operation
textual copied to clipboard

Change StringKey to simple strings. Fix ordering issue

Open merriam opened this issue 7 months ago • 3 comments

Please review the following checklist.

  • [X] Docstrings on all new or modified functions / classes
  • [?] Updated documentation
  • [n/a] Updated CHANGELOG.md (where appropriate)

DataTable's StringKey was recently exposed, meaning users could try to compare them. Unfortunately, this was causing an a comparison between str and None: StringKey("a string") < StringKey(). To solve the problem and simplify the class, either a StringKey value is the supplied string or the string representation of its id().

Test included, if you want to see it break before applying this change.

merriam avatar Jul 30 '24 06:07 merriam