textual icon indicating copy to clipboard operation
textual copied to clipboard

Add explicit Unmount event

Open Tinche opened this issue 3 years ago • 2 comments

Not sure if this is intended or not. I was handling app cleanup in my App.on_remove so I was surprised it was being triggered when a child screen gets popped off. I can provide a snippet if need be.

Tinche avatar Oct 26 '22 11:10 Tinche

The remove message is something different. It asks the App to remove something from the DOM. Should really be private.

We don't have a convenient place to clean things up. What we probably need is an UnMount event.

willmcgugan avatar Oct 26 '22 12:10 willmcgugan

I see, alright. Can close this or keep it open to track a place for cleanup, your choice. Thanks.

Tinche avatar Oct 26 '22 13:10 Tinche

We have an UnMount event now.

willmcgugan avatar Jan 17 '23 10:01 willmcgugan

Don't forget to star the repository!

Follow @textualizeio for Textual updates.

github-actions[bot] avatar Jan 17 '23 10:01 github-actions[bot]