rich icon indicating copy to clipboard operation
rich copied to clipboard

Published 20 hours ago • verified publisher icon Textualize

Fix CHANGELOG.md

Open rodrigogiraoserrao opened this issue 2 years ago • 4 comments

Type of changes

  • [x] Documentation

Checklist

  • [x] I accept that @willmcgugan may be pedantic in the ~~code~~ review.

Description

The changelog had missing/wrong compare links for most recent and oldest versions. I see some compare links are present even if the underlying tags were not created, so I followed this style and created all links as if the tags existed.

rodrigogiraoserrao avatar Aug 06 '22 08:08 rodrigogiraoserrao

Checking why the MacOS on Py3.11 failed, and it doesn't look like it's this PR's fault, but maybe I misunderstood the error.

rodrigogiraoserrao avatar Aug 06 '22 16:08 rodrigogiraoserrao

Yeah, looks environment related. Will try a rerun.

willmcgugan avatar Aug 06 '22 17:08 willmcgugan

The Mac build passed after your rerun, so it does look like it was env related. Who's at fault, here..?

rodrigogiraoserrao avatar Aug 08 '22 12:08 rodrigogiraoserrao

Beats me. We do have some integration tests which may suffer from race conditions. One of the pains of concurrent programming.

Unrelated to this PR though!

willmcgugan avatar Aug 08 '22 13:08 willmcgugan

obrigado

willmcgugan avatar Aug 17 '22 13:08 willmcgugan

De nada. I think you need to approve before this gets auto-merged 🙃

rodrigogiraoserrao avatar Aug 17 '22 20:08 rodrigogiraoserrao