Progress: Add .get_task_elapsed(TaskID)
Issue #2344
Type of changes
- [ ] Bug fix
- [X] New feature
- [ ] Documentation / docstrings
- [ ] Tests
- [ ] Other
Checklist
- [X] I've run the latest black with default args on new code.
- [ ] I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
- [ ] I've added tests for new code.
- [X] I accept that @willmcgugan may be pedantic in the code review.
Description
Hello! Related #2344. I didn't think adding a test for this was specifically necessary, since it's just adding a getter for an existing value.
It's also entirely possible you already have a better way of doing this!
A test is always necessary, I'm afraid!
Codecov Report
Merging #2345 (80968e9) into master (14d47c9) will decrease coverage by
0.19%. The diff coverage is94.73%.
@@ Coverage Diff @@
## master #2345 +/- ##
==========================================
- Coverage 98.88% 98.68% -0.20%
==========================================
Files 73 73
Lines 7629 7707 +78
==========================================
+ Hits 7544 7606 +62
- Misses 85 101 +16
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 98.68% <94.73%> (-0.20%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| rich/_export_format.py | 100.00% <ø> (ø) |
|
| rich/cells.py | 100.00% <ø> (ø) |
|
| rich/live.py | 97.90% <40.00%> (-2.10%) |
:arrow_down: |
| rich/progress.py | 92.48% <66.66%> (-0.26%) |
:arrow_down: |
| rich/console.py | 98.29% <96.03%> (-0.49%) |
:arrow_down: |
| rich/_inspect.py | 100.00% <100.00%> (ø) |
|
| rich/_wrap.py | 100.00% <100.00%> (ø) |
|
| rich/box.py | 100.00% <100.00%> (ø) |
|
| rich/control.py | 100.00% <100.00%> (ø) |
|
| rich/style.py | 100.00% <100.00%> (ø) |
|
| ... and 7 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 695256c...80968e9. Read the comment docs.
Fair enough! Before I do that though, just wanted to confirm that this would be an appropriate solution for #2344 ?
Closed, assumed stale.