ti-bdebstrap icon indicating copy to clipboard operation
ti-bdebstrap copied to clipboard

scripts/build_distro.sh : fix typo setting ROOTFS_DIR

Open r2rien opened this issue 1 year ago • 5 comments

Just a curly brace leftover typo

r2rien avatar Sep 24 '24 13:09 r2rien

Is ROOTFS_DIR used anymore? Could just delete this whole line.

glneo avatar Sep 24 '24 18:09 glneo

Is ROOTFS_DIR used anymore? Could just delete this whole line.

true, not used in ti-bdebstrap. my intent was to have at least the script functional/without errors. feel free to reject/close this MR and fix it in another way

r2rien avatar Sep 24 '24 20:09 r2rien

Please update your commit message to include it!

Feel free to add the tag: Signed-off-by: Antoine <[email protected]>

r2rien avatar Sep 24 '24 20:09 r2rien

Is ROOTFS_DIR used anymore? Could just delete this whole line.

true, not used in ti-bdebstrap. my intent was to have at least the script functional/without errors. feel free to reject/close this MR and fix it in another way

Fair enough, we can take this current patch then remove the line ourselves later if needed.

We are investigating moving away from all this custom scripting towards a more community supported solution, such as https://github.com/ilbers/isar. So these scripts might not be around at all much longer..

glneo avatar Sep 25 '24 16:09 glneo

We are investigating moving away from all this custom scripting towards a more community supported

well noted that you might be moving to openembedded/yocto with isar "vendoring" thanks for this info! Is there any timed (even aproximately) roadmap for it ?

r2rien avatar Sep 27 '24 09:09 r2rien