weston.service : rather handle --idle-time from /etc/xdg/weston/weston.ini
When "--idle-time" is specified in weston.service cmdline, It will supersede any value set in /etc/xdg/weston/weston.ini, becoming useless.
This MR is proposing to handle rather this "--idle-time" value in a new provided weston.ini file in target dir, achieving strictly same result (setting it to 0 == de-activating it), but letting any downstream test job testing/debugging resuming from suspend, adding much less divergence from master branch, thus easier to maintain.
thanks in advance
Hi @r2rien
Thanks for the PR.
Since ExecStart would pick "--idle-time" from weston.ini, idle-time is still 0, unless you edit the ExecStart line in weston.service file. But if you have to manually edit the weston.service file to override value of --idle-time, then you could have done that even earlier. So could you please explain your specific use-case which would benefit from this PR? AFAIK you can't pass arguments in systemctl (re)start <service> commands either.
Hi, thanks for your review
Since ExecStart would pick "--idle-time" from
weston.ini, idle-time is still 0
As I was telling, whatever is specified in weston.ini is superseded by --idle-time value in weston.service.
Thus my intent is to have to only modify weston.ini in /etc precisely without having to restart weston.service
Since the original --idle-time value in weston.service was 0,
I kept this value in weston.ini to submit a PR :
- guaranteed without any change/impact against current ti version:
- to maximize its chance of being accepted
- while this value will be the only thing to branch in our downstream repo
Hope I clarified my intent enough - cheers