LilyTerm icon indicating copy to clipboard operation
LilyTerm copied to clipboard

Distinct foreground/background color settings (also for schemes, required for Solarized)

Open blueyed opened this issue 11 years ago • 6 comments

Currenty LilyTerm's color schemes only define the palette, but not which color to use for fore- and background.

Given the Solarized theme, the foreground and background needs to be specified separately. See http://ethanschoonover.com/solarized#usage-development.

The colors are taken from the palette, but are not at the expected/used position (given the dark theme at least).

blueyed avatar May 20 '14 13:05 blueyed

You may custom the color theme via right click menu -> [change the colors].

Tetralet avatar May 22 '14 08:05 Tetralet

Yes, but it would be nice if this would be possible already from selecting a theme.

blueyed avatar May 22 '14 11:05 blueyed

[change the colors] => [change the foreground color] appears to change the palette itself.

While it seems to work in the current LilyTerm instance, where you've changed it, the color palette is off when saving the profile and starting a new instance.

E.g. when changing the foreground for the solarized theme, the colors in the Vim solarized theme are off when the saved (custom) profile is being used.

Also, when setting the foreground color, the background_color setting appears to get reset (when saving the profile).

blueyed avatar May 22 '14 11:05 blueyed

~~While the initial request still stands (allow to define fg/bg colors in the theme), I found that editing the profile conf directly works: defining foreground_color and background_color therein seems to work as expected. The problem described above resulted from using the "Save settings" context menu option, which also sets custom_theme = 1, but not the ColorX settings (they were empty). The problem might be that setting the foreground (and/or background) color triggers the custom_theme=1 change, although the theme/palette itself hasn't changed (and even has empty color values).~~

It appears that changing the foreground color in LilyTerm needs to also change the palette: there appears to be no concept of a distinct foreground color in LilyTerm yet: it is bound to a specific entry from the palette, and therefore changes the theme palette itself (and requires custom_theme=1).

blueyed avatar May 22 '14 12:05 blueyed

@Tetralet Can you provide more feedback regarding this issue, especially my last comment? Would it be possible for LilyTerm themes to have additional foreground and background colors? For the solarized theme variants, the palette would be the same, but LilyTerm would allow to set the foreground/background colors additionally.

blueyed avatar Sep 12 '14 17:09 blueyed

The rule of ansi theme is very simple in LilyTerm.

LilyTerm uses the 16 colors palette. color0(background_color) = Background Color color1 = Dark Red color2 = Dark Green ... color14 = Bright Cyan color15(foreground_color) = Foreground Color

The palette in themes will be replace with custom color if you choosing [libvte + custom] in theme menu; And it will use the default palette data in themes if you choosing [libvte] only.

Tetralet avatar Sep 13 '14 14:09 Tetralet