Testura.Code icon indicating copy to clipboard operation
Testura.Code copied to clipboard

added net7 as target framework

Open jeffward01 opened this issue 3 years ago • 4 comments

Hello!

I added net7 as a target framework. It should work fine, let me know if there are any issues with it.

Few questions for you:

1.) I saw this code here: do you also want to add a target of .netstandard2.0?

<PropertyGroup Condition="'$(Configuration)|$(TargetFramework)|$(Platform)'=='Debug|netstandard2.0|AnyCPU'">
    <WarningLevel>3</WarningLevel>
</PropertyGroup>

2.) How do you 'build' this and publish to nuget.org? It would be cool to add 'SourceLink' but im not sure how you publish this. Depending if you use GitHub or Azure Pipelines, the package will be different.


Let me know if there are any issues or questions!

Thanks

jeffward01 avatar Nov 13 '22 20:11 jeffward01

One more thing I should add:

  • When you target multiple frameworks in CI / CD - you should use dotnet build tools and not nuget build tools
  • Ensure dotnet sdk 7.0.100 or greater is used in the CI / CD pipeline

If you don't use CI / CD - I can set up a Github action that performs this, I just need you to add your nuget API key

Thanks!!

Jeff

jeffward01 avatar Nov 13 '22 20:11 jeffward01

@MilleBo - I believe that I cannot approve my own PR and need your approval and review for this

jeffward01 avatar Nov 20 '22 22:11 jeffward01

@MilleBo - bump on this please <3

jeffward01 avatar Nov 24 '22 01:11 jeffward01

Sorry for the later answer. Saw that we had three different pull requests with .NET 7 now. Guess the other two should be remoed and this one should be corrected with correct syntax (net7.0)?

MilleBo avatar Dec 07 '22 20:12 MilleBo