TestRunnerSRL
Creation of Skull Mask/Mask of Truth Misc Hint
Creates a Skull Mask and Mask of Truth misc hint, located on the sign in the Deku Theater. The hint will hint either one individually if they are selected, or both if both are selected as a dual hint.
The hint texts are missing final punctuation.
In the big poe misc hint PR, a location was added to the logic for the hint. I'm curious why that was necessary there but not here?
The hint texts are missing final punctuation.
In the big poe misc hint PR, a location was added to the logic for the hint. I'm curious why that was necessary there but not here?
Will update punctuation. Can you show me exactly what you were talking about for the big poe?
The hint texts are missing final punctuation. In the big poe misc hint PR, a location was added to the logic for the hint. I'm curious why that was necessary there but not here?
Will update punctuation. Can you show me exactly what you were talking about for the big poe?
I found it. I'll add that, i see its there for the skull hints as well.
We'd like to see some more testing:
- Make sure it removes the hint from gossip stones if the misc. hint is on
- How it behaves if one or both masks are disabled checks
- If it breaks if spoiler log/hints are disabled since it broke the big Poes one
I’ve already tested all of this. I can get some screenshots though Sent from my iPhoneOn Apr 18, 2025, at 8:49 PM, Fenhl @.***> wrote: We'd like to see some more testing:
Make sure it removes the hint from gossip stones if the misc. hint is on How it behaves if one or both masks are disabled checks If it breaks if spoiler log/hints are disabled since it broke the big Poes one —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
fenhl left a comment (OoTRandomizer/OoT-Randomizer#2343) We'd like to see some more testing:
Make sure it removes the hint from gossip stones if the misc. hint is on How it behaves if one or both masks are disabled checks If it breaks if spoiler log/hints are disabled since it broke the big Poes one
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
I left the hint even if it’s disabled since that’s how the skull house misc hints were. There was discussion in dev-public about this when I was working on it, and the decision was made to follow the same way the skull house hints worked and if you select you want the misc hint for one or both of the masks, even if it’s disabled it will hint it.Not aware of how the poe misc hint broke spoiler logs, but I dug through a fair amount during testing before PRing and they looked fine to me.I’ll get the other edits you asked for when I have some time next week.Sent from my iPhoneOn Apr 19, 2025, at 4:00 AM, Jay Kilpatrick @.> wrote:I’ve already tested all of this. I can get some screenshots though Sent from my iPhoneOn Apr 18, 2025, at 8:49 PM, Fenhl @.> wrote: We'd like to see some more testing:
Make sure it removes the hint from gossip stones if the misc. hint is on How it behaves if one or both masks are disabled checks If it breaks if spoiler log/hints are disabled since it broke the big Poes one —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
fenhl left a comment (OoTRandomizer/OoT-Randomizer#2343) We'd like to see some more testing:
Make sure it removes the hint from gossip stones if the misc. hint is on How it behaves if one or both masks are disabled checks If it breaks if spoiler log/hints are disabled since it broke the big Poes one
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>
I've opened https://github.com/Jaybone25/OoT-Randomizer/pull/9 addressing the review comments.