OoT-Randomizer icon indicating copy to clipboard operation
OoT-Randomizer copied to clipboard

Other tab changes

Open aofengen opened this issue 1 year ago • 2 comments

Update of #2183. From original PR:

The One Major Item per Dungeon setting is designed to make all dungeons similar in value relative to both each other and the world in general. While it does this job extremely effectively, its very nature makes it almost incompatible with many settings, and effectively causing any seed rolled with Randomize Main Settings to fail close to 50% of the time if this option hits as True (it is possible to have a successful generation with the option turned on, but the likelihood drops dramatically).

In moving the setting from the Main Rules to the Other tab, the functionality of the setting is preserved while eliminating the detrimental effects on the Randomize Main Rules setting. Additionally, the other tab has been redesigned and had settings re-ordered to fit the generator better.

aofengen avatar Aug 06 '24 23:08 aofengen

It's too late now for this one, but for future reference, it's generally preferred to rebase/force-push an existing PR branch instead of opening a new PR to change the branch. We can help with git stuff like that in #dev-public-talk on Discord.

fenhl avatar Aug 06 '24 23:08 fenhl

I've opened https://github.com/aofengen/OoT-Randomizer/pull/1 to reorder SettingsList.py (and by extension spoiler logs) to match these changes.

fenhl avatar Aug 07 '24 02:08 fenhl