OoT-Randomizer icon indicating copy to clipboard operation
OoT-Randomizer copied to clipboard

Adjust blue warp item behavior

Open fenhl opened this issue 1 year ago • 3 comments

This PR changes how dungeon rewards give out their items: A “rewards as items” flag is introduced, which works similarly to the existing “songs as items” and “fairy ocarina as item” flags.

  • When disabled, blue warps now simply run the item's effect function and display its text box. This has the nice side effect of removing the interruption from the get item animation while keeping the speedups introduced in #2034.
  • When enabled, the item is now added to the delayed item queue, causing it to be given after warping.

Neither behavior will prevent the blue warp entrance from activating. If my analysis at https://github.com/OoTRandomizer/OoT-Randomizer/issues/2230#issuecomment-2141059686 is correct, this fixes #2230.

fenhl avatar Jun 25 '24 03:06 fenhl

Here's what it looks like without rewards as items:

https://github.com/OoTRandomizer/OoT-Randomizer/assets/641386/7349ef8d-bc5a-4544-accd-4a8624f42ac5

fenhl avatar Jun 25 '24 06:06 fenhl

Can confirm this fixes the bug with the setup from https://github.com/OoTRandomizer/OoT-Randomizer/issues/2230#issuecomment-2193696608 without rewards as items:

OoT A7A63 FMWRA80NZT.webm

Howewer, the rewards as items flag doesn't seem to be set correctly:

OoT 5357C 60ZC6AXQ6Y.webm

fenhl avatar Jun 27 '24 05:06 fenhl

Howewer, the rewards as items flag doesn't seem to be set correctly:

This turned out to be a bug with the size of CFG_BIGOCTO_OVERRIDE_KEY not having been adjusted for #2069. Now that that's fixed, rewards as items works correctly as well:

OoT 5357C PQ2VHJI0DP.webm

fenhl avatar Jun 27 '24 05:06 fenhl