OoT-Randomizer icon indicating copy to clipboard operation
OoT-Randomizer copied to clipboard

Dual hints should not hint locations in precompleted dungeons

Open Level80Starmie opened this issue 1 year ago • 1 comments

This issue was previously worked for Sometimes hints in pulls #2085 and #2097 but doesn't seem to account for dual hints. Tested the same way Fenhl did in the testing for 2097, I've updated the plando to precomplete all 8 dungeons and removed all the OW duals, we still get dual hints. The function starting at 954 in Hints.py looks to be doing the check if the location is precompleted, not sure if dual hints containing two locations rather than one might be causing some issue.

precompleted-dual-test.json OoT_C57A7_XPTFS1AC93_Spoiler.json

Level80Starmie avatar Jun 09 '24 12:06 Level80Starmie

The fix for this is most likely analogous to the one made for Sometimes hints in #2097.

fenhl avatar Nov 09 '24 01:11 fenhl