OoT-Randomizer icon indicating copy to clipboard operation
OoT-Randomizer copied to clipboard

Spoilers with Randomize Main Settings enabled are not reproducible as plandos

Open mracsys opened this issue 1 year ago • 2 comments

With Randomize Main Settings enabled in a plando, the randomizer attempts to reroll all world-specific settings even if they are defined in the "randomized_settings" section. At a minimum this leads to a new seed that won't respect the input plando. At worst this causes generation failure due to settings conflicts.

As an example, if shopsanity is randomized to "off" in the spoiler/plando and regenerating rolls any of the numeric shopsanity settings, the randomizer crashes attempting to generate shop prices on this line:

https://github.com/OoTRandomizer/OoT-Randomizer/blob/068f85ee6b49fc5cd6307cd409f65f43bcfdedc1/World.py#L683C27-L683C27

I also noted trial selection causing conflicts, but did not dig deeper.

mracsys avatar Oct 14 '23 19:10 mracsys

https://github.com/OoTRandomizer/OoT-Randomizer/issues/1449 is a related/duplicate issue.

flagrama avatar Oct 14 '23 20:10 flagrama

Additionally, settings on the Main tab that are not randomized, such as Silver Rupee Shuffle, are not saved in the spoiler even if they are shuffled. See attached example.

OoT_17377_42EQGLKORH_Spoiler.txt

mracsys avatar Oct 14 '23 20:10 mracsys