Shuffle magic jars

[SlyryD]

Shuffle large and small magic jars

• Magic jars become blue rupees if you don't have magic yet
• Large magic jars appear in the junk item pool
• Update LocationList.py to show large and small magic jars as the vanilla item where applicable
• Add hints

Create a new object file for the magic meter with magic jar colors swapped

• Increase extended object table size
• Add new cosmetics version for patching the colors based on magic color

Screenshots

Magic meter model

Double magic model

Magic meter with correct model colors

Double magic with correct model colors

Magic meter from a distance

Double magic from a distance

Magic jar before magic

Magic jar after magic

[cjohnson57]

Can you add a pic of your magic meter model?

[r0bd0g]

Since those chests in Shadow are essentially blue rupees in vanilla, they should stay blue rupees in the item pool. You can consider changing them to magic jars under the 'fix broken drops' setting, but that seems weird?, I think we've talked about it before on a previous PR though I don't remember exactly how that shook out. I'm really opposed to changing them to jars out of nowhere, when they've been blue rupees for over 20 years.

I think some pots might be random between being either a large jar or a small jar? Is that true? How have you opted to handle that, if so?

[SlyryD]

Since those chests in Shadow are essentially blue rupees in vanilla, they should stay blue rupees in the item pool. You can consider changing them to magic jars under the 'fix broken drops' setting, but that seems weird?, I think we've talked about it before on a previous PR though I don't remember exactly how that shook out. I'm really opposed to changing them to jars out of nowhere, when they've been blue rupees for over 20 years.

I think some pots might be random between being either a large jar or a small jar? Is that true? How have you opted to handle that, if so?

The magic jars are added to the junk pool. I actually don't think the vanilla item in LocationList matters for junk items.

No, pots are either small jar or large jar. Rob isn't shuffling flex drop pots yet.

[r0bd0g]

I think the magic jars in those chests in shadow/spirit will put magic jars into the default item pool, which is what I disagree with, since they're normally blue rupees.

I think, for example, the pots in the lobby of mq fire are random between small and big, like 25% chance of big or something, but I'm not 100% sure. I was asking whether small was used for all of those, or if it's arbitrary between small/big or what.... Always assuming random size magic drops actually exist.

[rrealmuto]

I think the magic jars in those chests in shadow/spirit will put magic jars into the default item pool, which is what I disagree with, since they're normally blue rupees.

I think, for example, the pots in the lobby of mq fire are random between small and big, like 25% chance of big or something, but I'm not 100% sure. I was asking whether small was used for all of those, or if it's arbitrary between small/big or what.... Always assuming random size magic drops actually exist.

I do not think magic drops from pots being big/small is random. It is a property coded into the pot actor's spawn variable.

[SlyryD]

I think the magic jars in those chests in shadow/spirit will put magic jars into the default item pool, which is what I disagree with, since they're normally blue rupees.

That does seem to be the case. I'll switch chest magic jars back to blupees.

[alkalineace]

Those magic jars that became blue rupees in the vanilla game could still become magic jars in the Fix broken drops setting I feel.

[r0bd0g]

We talked about tying it to fix broken drops previously (in the fix broken drops pr) and it wasn't done, but with an actual implementation of magic jars it might be worth revisiting.