Cutscenes being skipped leads to incorrect time of day in some cases

[ETR-BTF]

This is not a new bug. I'm just opening this issue for documentation purposes.

Some events that normally set the time in vanilla due to a cutscene either set it to the incorrect time or don't set it at all in OoTR due to cutscenes being skipped.

all blue warps should also set the time, although water ends up setting it to morning rather than noon talking to zelda and going adult should both set it to noon since the normal cutscene sequences go through the cs map and chamber of sages, respectively getting suns should advance it based on the current time of day (this is the natural in-game way of getting dampe time easily) and probably a few others im forgetting

Additionally, the "Default (10:00)" starting time option in the gui is a bit of a misnomer since in vanilla you don't get control over Link until noon. This is because by the time this setting was added, people were already used to 10:00 being the "default" starting time of day in Randomizer. So "default" doesn't refer to vanilla, but OoTR.

[r0bd0g]

Sometimes it can be a bit weird to handle this since it might depend on the speed that you advance through the cutscene.

IMO the most egregious case currently in the release (and it's been this way for forever) is Zelda's Lullaby not setting it to noon.

The one for going adult is a bit weird since nothing really happens when you go adult for the first time. And what if you start as adult, should it still make it noon the first time you swap or the first time you go adult again? But if there's ever a light medallion check in ToT I might suggest getting that make it noon.

[r0bd0g]

I want to point out also that beating dungeons setting time of day might actually cause some non-repeatable access in rare cases.

[fenhl]

It's worth noting that #2034 currently contains code that explicitly sets time of day in blue warps to emulate the vanilla behavior. We may want to consider removing that code to address the nonrepeatable access.

[fenhl]

With #2287, we have eliminated the last instance of nonrepeatable ToD access that could cause softlocks, by making blue warp ToD changes repeatable. We should avoid reintroducing nonrepeatable ToD access, so changing ToD when going adult for the first time or checking Song from Royal Familys Tomb should not be added. Therefore, the remaining things to do here are:

• [ ] Reintroduce Song from Impa setting time to noon. This is safe because the cutscene takes you either to Hyrule Field or the Hyrule Castle grounds, depending on ER settings, both of which are locations where ToD passes.
• [ ] Decide what to do with the starting ToD options.
  • I could see simply changing the default value of the setting to noon for accuracy with respect to vanilla, but keeping the 10:00 option for the purpose of racing presets, since the racing community would most likely want to stay on that option. Would that make sense? Is fixing the inaccuracy worth the confusion the change would cause?

[r0bd0g]

I would like to be able to select any starting time of day.

(I've heard there are some weird edge cases right around the transition between days and nights. Does anybody know what the specifics of those are? There might need to be some logic adjustments to be able to handle those.)

[fenhl]

That could be a decent way of solving this. Maybe just changing the dropdown to a 0–23 slider to allow selecting any full hour would work without having to exhaustively check if these edge cases exist.