Terry Howe

Results 339 comments of Terry Howe

> What do you want to say when you print the content of the output of golangci-lint ? Thanks, I was just posting the errors from the rebase

It might be easier to merge a couple smaller pull requests on just a few files. I'd like to see this work merged, I'm a testify fan.

It might be easier to merge a couple smaller PRs. Thanks for creating this pull request!

Conflicts. Also, it would be convenient if the repository pull used the same round tripper as the registry pull if possible.

This code now exists in `toTOML` in `pkg/engine/funcs.go` https://github.com/helm/helm/blob/main/pkg/engine/funcs.go#L160

I think this makes sense, it should be changed to something like the other methods return: ``` // Swallow errors inside of a template. return "" ```

Do you want to open a pull request?

For what you want to do, I don't think `wrap` makes sense. Maybe `substr`? The documentation: https://masterminds.github.io/sprig/strings.html https://masterminds.github.io/sprig/

I'm surprised there isn't an easier way.

> is it a valid action? should we support it? That is nothing helm can support, it is allowed by repositories. People do not need to use helm to push...