ansible-modules-hashivault icon indicating copy to clipboard operation
ansible-modules-hashivault copied to clipboard

configuring allowed_other_sans parameter in hashivault_pki_role broken

Open lesinjan opened this issue 2 years ago • 2 comments

Hello! It seems that configuration of allowed_other_sans parameter in hashivault_pki_role is broken and fails with "config item 'allowed_other_sans' has wrong data format" for any valid value. As far as I can tell it is due to wrong parameter type where it was supposed to get changed from 'str' to 'list', but was changes to 'type'.

https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_pki_role.py#L127

lesinjan avatar Aug 11 '23 08:08 lesinjan

Sounds like a docs bug and a one liner. Do you want to submit a PR?

TerryHowe avatar Aug 11 '23 10:08 TerryHowe

Not just a docs bug, as it seems documentation is also used for simple parameter validation. But you are right, should be a one liner. As for PR, it seems I can't create a branch for the issue. Missing the button.

lesinjan avatar Aug 11 '23 10:08 lesinjan