ansible-modules-hashivault icon indicating copy to clipboard operation
ansible-modules-hashivault copied to clipboard

add new and rename old params

Open ceesios opened this issue 2 years ago • 3 comments

WIP: requires this pr to be merged first:

Add support for diff mode.

Renamed and added aliases to match vault api and HVAC names.

  • bind_dn = binddn
  • bind_pass = bindpass
  • discover_dn = discoverdn
  • group_attr = groupattr
  • group_dn = groupdn
  • group_filter = groupfilter
  • upn_domain = upndomain
  • user_attr = userattr
  • user_dn = userdn

Ordered documentation and parameters to prevent missing or duplicate parameters.

removed unsupported parameter "description" ignore "use_pre111_group_cn_behavior" in read since it is undocumented and unsupported by HVAC.

add new parameters:

  • anonymous_group_search
  • client_tls_cert
  • client_tls_key
  • connection_timeout
  • max_page_size
  • request_timeout
  • token_bound_cidrs => fixes #397
  • token_explicit_max_ttl
  • token_no_default_policy
  • token_num_uses
  • token_period
  • token_policies
  • token_type
  • userfilter => fixes #407
  • username_as_alias

ceesios avatar Jul 17 '23 09:07 ceesios

Hmm, this would require a major version bump

TerryHowe avatar Jul 17 '23 12:07 TerryHowe

@TerryHowe are you sure this would require a major version bump? All parameters are aliased so it should be backwards compatible. And the use_pre111_group_cn_behavior and description were never in hvac for as far as i can see.

ceesios avatar Jul 17 '23 13:07 ceesios

Might be easiest to change this module to use one parameter like "configuration" and remove the dependency on the underlying implementation although this would have lest validation.

TerryHowe avatar Feb 12 '24 22:02 TerryHowe