ansible-modules-hashivault icon indicating copy to clipboard operation
ansible-modules-hashivault copied to clipboard

LDAP Config Module Doesn't have token_bound_cidrs support

Open adawalli opened this issue 3 years ago • 3 comments

First off, love this module - amazing work.

Would you consider adding token_bound_cidrs to the hashivault_auth_ldap module? Thankfully, you have this on OIDC roles and approles and it just appears to be missing on this one login method.

Thank you for your consideration!

https://www.vaultproject.io/api/auth/ldap#token_bound_cidrs

adawalli avatar Mar 08 '22 14:03 adawalli

Something like this probably https://github.com/TerryHowe/ansible-modules-hashivault/blob/main/ansible/modules/hashivault/hashivault_oidc_auth_role.py#L65

Not hard to do, just adding the docs, parameters and any desired state type logic

TerryHowe avatar Mar 09 '22 01:03 TerryHowe

I can submit a PR tomorrow

adawalli avatar Mar 09 '22 02:03 adawalli

Unfortunately, HVAC doesn't support CIDRs yet for LDAP - I will have to get it added there first.

How hard will it be to add guards in the code for folks that have HVAC <= the current version?

adawalli avatar Mar 09 '22 20:03 adawalli