ansible-modules-hashivault icon indicating copy to clipboard operation
ansible-modules-hashivault copied to clipboard

Conversion to Ansible Collection

Open onitake opened this issue 5 years ago • 7 comments

This PR converts the module into an Ansible collection.

Fixes: #234

Still to do: Update the documentation and remove PyPi scripts.

It can be packaged with:

ansible-galaxy collection build

The package can then be installed into the user's home with:

ansible-galaxy collection install terryhowe-hashivault-4.5.2.tar.gz

To try it out, use the following playbook:

- hosts: test
  gather_facts: no
  collections:
   - terryhowe.hashivault
  tasks:
  - name: get test secret
    delegate_to: localhost
    hashivault_read:
      secret: test/secret
    register: new
  - debug:
      var: new.value

onitake avatar Jun 18 '20 16:06 onitake

Somehow I missed the notification on this PR, I need to look at this.

TerryHowe avatar Jul 08 '20 14:07 TerryHowe

I would really like to see this conversion to a collection happen!

teamosceola avatar Sep 04 '20 19:09 teamosceola

Any updates on this pr?

freeseacher avatar Nov 01 '20 15:11 freeseacher

I've cleared up the other issues and started working on this, but there is a lot for me to understand here.

TerryHowe avatar Nov 01 '20 19:11 TerryHowe

You should probably get rid of the hashivault_ prefix on all modules, in the process. Modules would be used in the terryhowe.hashivault.secret form instead of terryhowe.hashivault.hashivault_secret.

It seems possible to still support hashivault_ prefix for backward playbook compatibility. See https://opendev.org/openstack/ansible-collections-openstack/src/commit/94e518e42c3d08e227df1dcf2b9a2aad4429f00d/plugins/modules/server_info.py#L65

dr4Ke avatar Nov 04 '20 13:11 dr4Ke

I've fixed merge conflicts and pushed to a new branch https://github.com/TerryHowe/ansible-modules-hashivault/pull/315 but I'm going to leave this open a bit to get some more info out of this PR.

TerryHowe avatar Nov 08 '20 21:11 TerryHowe

must have :)

absynth76 avatar Apr 26 '21 13:04 absynth76

Stale

TerryHowe avatar Mar 11 '23 12:03 TerryHowe