terriajs icon indicating copy to clipboard operation
terriajs copied to clipboard

Published 20 hours ago • verified publisher icon TerriaJS

react-datepicker is missing peer dependencies

Open pjonsson opened this issue 9 months ago • 1 comments

Looking at https://npmgraph.js.org/?q=https%3A%2F%2Fgithub.com%2FTerriaJS%2Fterriajs%2Fblob%2Fmain%2Fpackage.json, the "Graph" tab to the right has a header "Missing peer dependencies (2)" where [email protected] is listed as wanting react@^0.14.0 || ^15.0.0 and react-dom@^0.14.0 || ^15.0.0, so I'm guessing this version does not support the React version used by TerriaJS?

The react-datepicker package is also causing the warning of react-popper and popper.js under the "Deprecated modules" header.

pjonsson avatar Feb 25 '25 13:02 pjonsson

It will upgraded as part of the react upgrade or as a follow-up; we have most of it completed, but we need to sort out other things and currently open PRs before creating a bunch of PRs for it to avoid constant merge conflicts

zoran995 avatar Feb 25 '25 14:02 zoran995

@zoran995, this issue is claimed to be fixed in your PR. Should we close it?

niktayv avatar Jul 24 '25 22:07 niktayv

The URL still works, so the issue I reported is solved, so I'll close this.

The react-anything-sortable and react-virtual packages are missing peer dependencies after upgrading to React 18 though, so they should probably be upgraded, but that is a separate issue.

pjonsson avatar Jul 24 '25 22:07 pjonsson