terriajs icon indicating copy to clipboard operation
terriajs copied to clipboard

Published 20 hours ago • verified publisher icon TerriaJS

CreateModel: stop shadowing variable

Open pjonsson opened this issue 1 month ago • 0 comments

What this PR does

Commit 5468fab7 introduced a workaround for TypeScript 3.4 which shadowed a variable. TerriaJS uses TypeScript 5 now, so inline the variable to eliminate the shadowing.

Test me

Run typescript and see that type checking still passes.

Checklist

  • [X] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • [ ] I've updated relevant documentation in doc/.
  • [ ] I've updated CHANGES.md with what I changed.
  • [X] I've provided instructions in the PR description on how to test this PR.

pjonsson avatar Jun 06 '24 19:06 pjonsson