terriajs icon indicating copy to clipboard operation
terriajs copied to clipboard

GitHub Workflows security hardening

Open sashashura opened this issue 2 years ago • 1 comments

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Sep 26 '22 11:09 sashashura

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 26 '22 12:09 CLAassistant

Do you have any questions?

sashashura avatar Oct 13 '22 14:10 sashashura

@steve9164 @nf-s could you please review it?

sashashura avatar Dec 01 '22 01:12 sashashura

An example of workflow run with unrestricted permissions: image

sashashura avatar Dec 01 '22 01:12 sashashura