terriajs
terriajs copied to clipboard
Tsify explorer window and data catalog
What this PR does
Fixes #5204
Move of explorer window and data catalog to ts and styled-components.
Test me
- Important note on testing, test this against scene editor
Checklist
- [ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
- [ ] I've updated relevant documentation in
doc/
. - [ ] I've updated CHANGES.md with what I changed.
- [ ] I've provided instructions in the PR description on how to test this PR.
Got the prettier v2 merge & merge from main
done. Also it should deploy to http://ci.terria.io/z995-ts-ew-6466/.
Hi @steve9164, are there any plans to merge this? I might get some time next week to get this in sync with the latest main.
Yes. With some small fixes to the styling we can get this merged. Here are a couple of cases:
- Groups should have a horizontal line when expanded (they probably shouldn't have horizontal lines when collapsed on top level, as they currently do in main):
Before:
After:
- Font weight should be 700 for groups (at all levels - main is currently incorrect at top level)
It might be worth waiting til next week for the React 18 upgrade to be merged into main (see #6902 - just fixing some tests on it now).
Fixed the mentioned styling issues. I am not quite sure if you meant all groups should have a horizontal line or only top-level so I added it only for top-level groups when expanded (subgroups don't have underline in main)