terriajs icon indicating copy to clipboard operation
terriajs copied to clipboard

Tsify explorer window and data catalog

Open zoran995 opened this issue 2 years ago • 6 comments

What this PR does

Fixes #5204

Move of explorer window and data catalog to ts and styled-components.

Test me

  • Important note on testing, test this against scene editor

Checklist

  • [ ] There are unit tests to verify my changes are correct or unit tests aren't applicable (if so, write quick reason why unit tests don't exist)
  • [ ] I've updated relevant documentation in doc/.
  • [ ] I've updated CHANGES.md with what I changed.
  • [ ] I've provided instructions in the PR description on how to test this PR.

zoran995 avatar Jul 31 '22 15:07 zoran995

Got the prettier v2 merge & merge from main done. Also it should deploy to http://ci.terria.io/z995-ts-ew-6466/.

tephenavies avatar Nov 22 '22 12:11 tephenavies

Hi @steve9164, are there any plans to merge this? I might get some time next week to get this in sync with the latest main.

zoran995 avatar Sep 24 '23 11:09 zoran995

Yes. With some small fixes to the styling we can get this merged. Here are a couple of cases:

  1. Groups should have a horizontal line when expanded (they probably shouldn't have horizontal lines when collapsed on top level, as they currently do in main):

Before: image

After: image

  1. Font weight should be 700 for groups (at all levels - main is currently incorrect at top level)

tephenavies avatar Sep 28 '23 02:09 tephenavies

It might be worth waiting til next week for the React 18 upgrade to be merged into main (see #6902 - just fixing some tests on it now).

tephenavies avatar Sep 28 '23 02:09 tephenavies

Fixed the mentioned styling issues. I am not quite sure if you meant all groups should have a horizontal line or only top-level so I added it only for top-level groups when expanded (subgroups don't have underline in main) Screenshot 2023-10-04 at 11 13 16

zoran995 avatar Oct 04 '23 09:10 zoran995