terriajs-server icon indicating copy to clipboard operation
terriajs-server copied to clipboard

Replace request with got

Open pjonsson opened this issue 1 year ago • 1 comments

Depends on: #177

This replaces the deprecated requests library with the got library.

Unfortunately got 14.x is required for permitting followRedirect to be a function, and got 14.x requires Node 20.

pjonsson avatar May 19 '24 18:05 pjonsson

After running yarn upgrade on top of this pull request, yarn audit reports 1 vulnerability which is rate limiting bypass in express-brute, and that vulnerability should be fixed by #162.

pjonsson avatar May 19 '24 18:05 pjonsson

This is still an interesting feature, but I will close it as inactive and take another look at porting the implementation from geoportal-server when I am get some free time. @pjonsson, feel free to open a new PR if you make any progress on this

zoran995 avatar Aug 08 '25 10:08 zoran995

@zoran995 Yeah, summer hasn't gone according to plans, too many urgent and important things at once. I mainly want request gone, if someone else does it I'm more than happy.

I'm pretty sure I did some things in this PR that was to compensate for the lack of ESM, can this package be switched to ESM now?

pjonsson avatar Aug 08 '25 10:08 pjonsson