Terrestria icon indicating copy to clipboard operation
Terrestria copied to clipboard

Migrate legacy Andisol ids

Open FewerFlaws opened this issue 4 years ago • 7 comments

Andisol dirt, grass blocks, and podzol use "basalt_dirt" "basalt_grass_block" and "basalt_podzol" within the namespace. This is inconsistent because the grass path and farmland blocks use "andisol_grass_path" and "andisol_farmland."

I imagine you already know about this and decided not to correct it. I'm just pointing it out in case it's an oversight. I noticed it while working on compatibility between Presence Footsteps and Terrestria =]

FewerFlaws avatar Dec 28 '20 10:12 FewerFlaws

Yeah, this cannot be reasonably changed without breaking worlds. Perhaps we can fix it in the transition to 1.17 by using a datafixer, but unfortunately I don't believe we can get datafixers to run easily between mod version changes.

Luckily, ultimately it doesn't really matter what the ids are.

Prospector avatar Dec 29 '20 00:12 Prospector

New development on this. REI displays "andisol_grass_path" in the interface, but F3 debug view reveals that a placed block uses "basalt_grass_path" 2020-12-28_22 56 55 2020-12-28_22 57 03

FewerFlaws avatar Dec 29 '20 07:12 FewerFlaws

Yeah, the item was added later after the rename.

Prospector avatar Dec 29 '20 14:12 Prospector

Surely the tooltip issue can be fixed, right? The name shown in the extended F3+H tooltip should be the actual namespace name so that mod authors can see the block and reference it properly. Fixing that shouldn't break anything.

FewerFlaws avatar Dec 29 '20 22:12 FewerFlaws

Oh, I didn't describe the issue with the grass path properly. Check out that first screenshot to see the issue. The Andisol grass path's extended tooltip is displaying the wrong namespace block ID.

FewerFlaws avatar Dec 29 '20 22:12 FewerFlaws

No it's not. Item IDs are different from block IDs.

Prospector avatar Dec 30 '20 03:12 Prospector

Oh, I understand. Thanks =]

On Tue, Dec 29, 2020 at 7:05 PM Prospector [email protected] wrote:

No it's not. Item IDs are different from block IDs.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TerraformersMC/Terrestria/issues/227#issuecomment-752311059, or unsubscribe https://github.com/notifications/unsubscribe-auth/ASBDWM5BWIEPZFCOMGIQQGDSXKKJJANCNFSM4VL3LERQ .

FewerFlaws avatar Dec 30 '20 03:12 FewerFlaws