ModMenu icon indicating copy to clipboard operation
ModMenu copied to clipboard

[#394] Fix 1.14 crash - Double check sorting is not null.

Open MagnusHJensen opened this issue 1 year ago • 3 comments

closes #394 And fix typo issue.

MagnusHJensen avatar Jul 11 '22 20:07 MagnusHJensen

Oh wow, well done! I can confirm that a config with {"sorting": null} causes the crash reported in https://github.com/TerraformersMC/ModMenu/issues/394#issuecomment-1059718948.

So this wasn't https://github.com/TerraformersMC/ModMenu/issues/128 because the fix for that actually was backported to 1.14 (see https://github.com/TerraformersMC/ModMenu/commit/21e041501a76ca74b04014a7289ac0fa9b53fe2e).

This issue is also present on the 1.15 branch, could you please port this fix there? 1.16 and higher reject invalid config values at load time so it's not a problem there.

Both 1.14 and 1.15 were before my time, @Prospector could you please handle merging and publishing this?

jackassmc avatar Jul 12 '22 05:07 jackassmc

Please update "modmenu.sorting.decending" in et_ee.json and ja_jp.json.

jackassmc avatar Jul 12 '22 05:07 jackassmc

Oh wow, well done! I can confirm that a config with {"sorting": null} causes the crash reported in #394 (comment).

So this wasn't #128 because the fix for that actually was backported to 1.14 (see 21e0415).

This issue is also present on the 1.15 branch, could you please port this fix there? 1.16 and higher reject invalid config values at load time so it's not a problem there.

Both 1.14 and 1.15 were before my time, @Prospector could you please handle merging and publishing this?

All done :D

MagnusHJensen avatar Jul 15 '22 18:07 MagnusHJensen

I thought this was merged already, sorry for the delay!

jackassmc avatar Dec 08 '22 01:12 jackassmc