Fix for JEI auto-input crash for mortars and steel flasks

[oosyrag]

What is the new behavior?

Fixes crash from hovering over JEI auto input button for certain recipes - mortars and steel flasks.

Implementation Details

Per https://github.com/emilyploszaj/emi/issues/942#issuecomment-2865571709, fixed by padding shaped recipes out to include a third row. Thanks @Notenoughmail!

Outcome

Addresses https://github.com/TerraFirmaGreg-Team/Modpack-Modern/issues/963, although maybe that issue should be kept open for additional items/cases? This is a bandaid fix for specific items that were reported, there may be more out there.

[Notenoughmail]

have you verified this fixes the crash when using the crafting upgrade in Sophisticated Backpacks? In my testing the game never crashed when using a normal crafting table. I ask because, as far as I'm aware, empty pattern rows are simply discarded by the deserializer and thus won't change EMI's behavior.

Also, shouldn't the water flask recipes be wrapped in TFC's damage inputs recipe type?

[oosyrag]

Yep, actually only tested in backpack but didn't try the crafting table. I'll go do that now.

I know previously when first encountering the crash I had confirmed crashing when hovering the + button for both the crafting table and backpack, but it worked fine in the inventory 2x2 grid.

[oosyrag]

I don't think it has to do with the shaped recipe size anymore, it has to do with the tfc damage inputs recipe type. When I added that wrapper, it started crashing again. The original mortar recipes also had it and crashed. When I commented out the wrapper, it was ok - same for the mortar. I reduced the iron flask recipe to two rows and it was still okay as well.

I did confirm there's no difference between backpack and crafting bench though - Both are either ok or crash in the same situations.

Is my syntax correct here? The top one crashes, and the bottom one is fine

	event.recipes.tfc.damage_inputs_shaped_crafting(
		event.shaped('waterflasks:iron_flask', [
			'AB',
			'CD'
		], {
			A: 'waterflasks:iron_flask',
			B: 'waterflasks:bladder',
			C: '#forge:cloth',
			D: '#forge:tools/knives'
		})
	).id('waterflasks:crafting/repair_iron');

//	event.recipes.tfc.damage_inputs_shaped_crafting(
		event.shaped('waterflasks:iron_flask', [
			'AB',
			'CD'
		], {
			A: 'waterflasks:broken_iron_flask',
			B: 'waterflasks:bladder',
			C: '#forge:cloth',
			D: '#forge:tools/knives'
		})
//	)
	.id('waterflasks:crafting/repair_broken_iron');```

[Notenoughmail]

huh, strange. when I was investigating (freshly installed TFG 0.9.5), the game only crashed within the Sophisticated Backpacks crafting, inventory and regular crafting worked regardless of the wrapper recipe type

but, yes the issue is with the damage ingredients wrapper, but also with the number of rows in the shaped recipe's pattern

EMI would crash with

event.recipes.tfc.damage_inputs_shaped_crafting(
  event.shaped('minecraft:dirt', [
    'AB',
    'DD'
  ], {
    A: '#forge:tools/knives',
    B: 'minecraft:obsidian',
    D: 'minecraft:gravel'
  })
);

but not with

event.recipes.tfc.damage_inputs_shaped_crafting(
  event.shaped('minecraft:dirt', [
    'AB',
    'D ',
    'D '
  ], {
    A: '#forge:tools/knives',
    B: 'minecraft:obsidian',
    D: 'minecraft:gravel'
  })
)

due to an error in its non-vanilla crafting recipe interpreter, so yes your syntax is correct

vanilla crafting recipes should work fine, though you may have to use kube's damage ingredient method to use durability, turning the recipe into one of kube's crafting type, which may also have this problem

all that said, if it doesn't crash and the ingredients are damaged like expected, I suppose its fine as is

[oosyrag]

I was unable to get this to work satisfactorily. The latest commit has damage_input wrapped recipes and padded recipes to 3x3, still crashes for me for both the crafting bench and backpack when mouse-over autofill button in JEI. Inventory crafting is fine.