Terminals icon indicating copy to clipboard operation
Terminals copied to clipboard

Published 20 hours ago • verified publisher icon Terminals-Origin

Implement MikroTik Winbox Plugin

Open Lillecarl opened this issue 8 years ago • 11 comments

Implements support for MikroTik WinBox connections within Terminals in "the same" way as Putty is implemented. 👍

Lillecarl avatar Sep 23 '17 12:09 Lillecarl

https://www.youtube.com/watch?v=5RTwsErKgSI

Lillecarl avatar Sep 23 '17 12:09 Lillecarl

Should probably be some test for this, but idk how to write those =)

Lillecarl avatar Sep 23 '17 16:09 Lillecarl

First of all i am happy to see such pull requests with adding features and contributing to our project. It gives me power to continue. But, here we have few things to consider:

  1. Should this kind of connection be provided out of the box or not?
  • Yes - than we need integration tests (see next point)
  • NO - i am fine, if we add this as separate repository, with isolated release cycle under your control and extend our user documentation pointing to your plugin download page.

  1. How to test?Probably with some docker environment, when possible (see Resources\TestData\DockerLab\ directory). Because we are currently overloaded with testing of currently supported protocols.

  2. How should i accept this, i have no experience with the Winbox tool.

jirkapok avatar Sep 25 '17 19:09 jirkapok

  1. I'd say getting this into master would give us a good advantage on mRemoteNG, but to me personally there's no need getting there right now, as long as we can merge the terminals.common changes =)
  2. I could host a MikroTik router on Amazon AWS, and add a readonly user to those tests
  3. See 2, it's a fairly simple tool.

Lillecarl avatar Sep 26 '17 06:09 Lillecarl

What about licensing. Did you check, if it is possible to deploy WinBox as part of another application?

jirkapok avatar Oct 02 '17 19:10 jirkapok

I'm honestly not sure about their redistribution terms, they can't be too strict considering i automatically publish WinBox if i open the WebUI to WAN.

If it would be an issue one could make the downloader install it instead.

Edit: I sent a mail to MikroTik checking if they have concerns regarding this.

image

Lillecarl avatar Oct 05 '17 20:10 Lillecarl

Considering no body is against, i will merge, when other features are finished.

jirkapok avatar Oct 14 '17 19:10 jirkapok

@jirkapok What other features are we talking about, is there anything i cal help out with? I'm eager to get winbox and http form filling into terminals, then we can start deploying it at work to our techs.

And i don't wanna maintain a custom Terminals version, i'd rather see all nice features upstream :)

Lillecarl avatar Oct 28 '17 13:10 Lillecarl

Please provide:

  • all kind of tests, like the other plugins have.
  • Move winbox.exe to resources directory (see putty.exe)
  • Update the installer to pack the plugin

jirkapok avatar Nov 03 '17 00:11 jirkapok

I won't be able to do this, i don't fully understand the installer. I'll leave this here if someone want's to pick it up at some point. I should be able to provide similar tests to Putty at some point though.

Lillecarl avatar Dec 01 '17 13:12 Lillecarl

Wow this is a great addition to Terminals, just wanted to voice my support for this feature, it will come in really handy

wolfen351 avatar Feb 21 '18 22:02 wolfen351