BUGOUT icon indicating copy to clipboard operation
BUGOUT copied to clipboard

Subtle failure in UNDO

Open Terkwood opened this issue 3 years ago • 5 comments

she went back 7 moves and then tried to go forward and it blocked up

Generally undo works, but sometimes it doesn't.

Is this about backend? If so, which service? Does sync impact this?

Or is it the frontend?

Can we describe the failure scenario more precisely? Sometimes after 60 undos you still cannot trigger this bug

  • [ ] make sure #456 doesn't impact this behavior

Terkwood avatar May 13 '21 16:05 Terkwood

We should create an integration testing app which can communicate with Redis and push undo commands, expect move undone events, push make move commands, expect acceptance. It should push many thousands of requests and detect failure. This would either rule out or blame the undo /changelog flow

Terkwood avatar May 15 '21 18:05 Terkwood

Advancing #486, then using it in the test harness, should help this

Terkwood avatar May 17 '21 12:05 Terkwood

Test harness should use #502 instead of #486

Terkwood avatar May 24 '21 17:05 Terkwood

This occurs infrequently when I test using personal devices. Can it be triggered more often if BUGOUT web client is running on an azure vm ?

Terkwood avatar Jun 26 '21 12:06 Terkwood

This failure state does not prevent unrelated games from proceeding. It does not log anything useful in undo service.

one potential plan

Write sync procedures into sync service and browser impl,so that silently failing UNDO requests can be reconciled

Terkwood avatar Jun 26 '21 15:06 Terkwood