Details-Damage-Meter icon indicating copy to clipboard operation
Details-Damage-Meter copied to clipboard

Add release.json to GitHub Release

Open pengc99 opened this issue 2 years ago • 8 comments

Before Start!

Make sure the bug also happen when Details! is the only addon enabled.

Describe the bug Current GitHub releases do not have a release.json or the correct zip packages for an addon manager such as WowUp to automatically parse and download the addon.

Attempting to add the addon via the GitHub releases link on WowUp results in an error: https://github.com/WowUp/WowUp/issues/1245

Suggestions Add separate ZIP files to the releases section for the addons directory from source. This can be done by zipping up the contents of the "plugin" folder. An example is attached here: Details-Damage-Meter-DetailsRetail.v9.1.0.8888.145.zip

Next add a release.json file that points to the ZIP file above to be released with each release. An example release.json below: {"releases":[{"filename":"Details-Damage-Meter-DetailsRetail.v9.1.0.8888.145.zip","nolib":false,"metadata":[{"flavor":"mainline","interface":90200}]}]}

pengc99 avatar May 17 '22 03:05 pengc99

Terciob is currently investigating alternative options for Details! hosting.

Flamanis avatar May 18 '22 04:05 Flamanis

Just got an in-game advertisement from this addon. "Details!: a new version is available, download it from Curse Forge app or website.".

No thanks, I will be doing neither of those things. I may just clone it from here, but I sure would prefer to update it in a free and open source update program.

markdall avatar May 24 '22 01:05 markdall

Just got an in-game advertisement from this addon. "Details!: a new version is available, download it from Curse Forge app or website.".

No thanks, I will be doing neither of those things. I may just clone it from here, but I sure would prefer to update it in a free and open source update program.

That message has been in the addon for literal years. It's not an advertisement. It's telling you the only place it is currently hosted. Should the addon be hosted elsewhere, I'm absolutely certain it will be updated.

Flamanis avatar May 24 '22 01:05 Flamanis

I would like to upvote this issue. It would be great to be able to use wowup or a similar opensource addon manager. I will not use curse/overwolf.

tgoncuoglu avatar May 24 '22 14:05 tgoncuoglu

As commented here: https://github.com/Tercioo/Details-Damage-Meter/issues/309#issuecomment-1168695402 I have made a repository to mirror this one and auto-publish wowup compatible releases.

JustusW avatar Jun 28 '22 13:06 JustusW

Hello,

Could we get a way to download the addon that is outside the disease that Curseforge is? If the author wants, he can host the addon on wago which displays adds or here on GitHub, similar to Plater. I (and probably many others) refuse to use Curseforge due to their very poor privacy history.

fsamareanu avatar Sep 15 '22 08:09 fsamareanu

It already is

Flamanis avatar Sep 15 '22 09:09 Flamanis

Plater has the proper release.json with it's version releases, so it's clearly something that's possible. Can we just work on adding that here?

jondeans avatar Oct 30 '22 04:10 jondeans