tenderly-cli icon indicating copy to clipboard operation
tenderly-cli copied to clipboard

Brownie configuration structure mismatch

Open zivkovicmilos opened this issue 3 years ago • 0 comments

Description

The current go specification that is used to unmarshal Brownie configuration YAML files does not conform to the official Brownie configuration file layout: https://github.com/Tenderly/tenderly-cli/blob/edaae487a2bff9ab118f2382bccb8f8144d9f6af/providers/deployment_provider.go#L22-L30

The Brownie config is currently unmarshalled into this structure here.

Proposed solution

Currently, I have a draft PR that includes a Brownie configuration read test, but doesn't modify the common Config structure.

The obvious solution here would probably be to create a separate configuration structure for each provider, because they can have subtle differences, and use that.

Should I open a separate PR that standardizes these configuration reads?

@delta003 @Riphal @mspuz

zivkovicmilos avatar Nov 13 '22 11:11 zivkovicmilos