dependency issue with hardhat-deploy-ethers

[samlaf]

See this issue that I opened in hardhat-deploy-ethers: https://github.com/wighawag/hardhat-deploy-ethers/issues/26

the creator of hardhat-deploy-ethers suggests that hardhat-tenderly does not hardcode its version of hardhat-ethers, to prevent such issues (hardhat-deploy-ethers is a fork of hardhat-ethers).

[iantanwx]

we are also blocked on this. It looks like moving @nomiclabs/hardhat-ethers to peerDependencies is sufficient. I will fork and test this later. As far as I can tell, hardhat-tenderly does not rely on any specific APIs of hardhat-ethers that would make it necessary to pin it in dependencies, since it is actually imported to wrap certain deployment functions to do automatic verification.

[iantanwx]

@samlaf adding the following to package.json works for yarn:

  "resolutions": {
    "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@^0.3.0-beta.13"
  }

See the yarn docs on resolutions for more. For npm, the equivalent is overrides.

[samlaf]

Oh wow ok I’ll give it a try when I get back to this project. Thanks :)

[fvictorio]

It looks like moving @nomiclabs/hardhat-ethers to peerDependencies is sufficient

Agree. Also worth mentioning that this is one of our recommended practices when building Hardhat plugins.

[sebastiantf]

tsc complaining several Duplicate identifier errors with @nomiclabs/hardhat-ethers

samlaf adding the following to package.json works for yarn:

  "resolutions": {
    "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@^0.3.0-beta.13"
  }

See the yarn docs on resolutions for more. For npm, the equivalent is overrides.

This resolved it for now

[matthewlilley]

@samlaf adding the following to package.json works for yarn:

  "resolutions": {
    "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@^0.3.0-beta.13"
  }

See the yarn docs on resolutions for more. For npm, the equivalent is overrides.

For those using PNPM

  "pnpm": {
    "overrides": {
      "@nomiclabs/hardhat-ethers": "npm:hardhat-deploy-ethers@^0.3.0-beta.13"
    }
  },