Regarding some details of updating the generator and discriminator

[yunfan0621]

Hi, thank you for sharing the implementation of your great work! And I have some concerns with the following line of code:

https://github.com/TencentYoutuResearch/Adv-Makeup/blob/f238d37bb3e2a13deef0f0270f6ea7c1be005d5a/model.py#L346-L348

Why do you clip the grad of the discriminator when updating the generator (maybe instead of clipping the grad of generator)? I fail to find the corresponding explanation in your paper.

I also notice that when updating the discriminator, fake images are not detached from the generator network (which is a common practice to stop the grad from being propagated to the generator). Do you intend to do so?

I really appreciate it if you could kindly solve my issues.

Best Regards