GFPGAN icon indicating copy to clipboard operation
GFPGAN copied to clipboard

New argument to force full processing, even when CUDA is not available.

Open jfcarr opened this issue 3 years ago • 5 comments

jfcarr avatar Mar 13 '22 16:03 jfcarr

Thanks, this got RealESRGAN to work with my GFPGAn for the first time ever!!!

One thing, for me, at least, as written it will not force ESRGAN, but if you change line 62 to True then it will work. Was that the intent? (Also, I had to get rid of Else BG_Upsampler=none, but I might have an older inference file)

zarc70 avatar Mar 14 '22 22:03 zarc70

Thanks, this got RealESRGAN to work with my GFPGAn for the first time ever!!!

One thing, for me, at least, as written it will not force ESRGAN, but if you change line 62 to True then it will work. Was that the intent? (Also, I had to get rid of Else BG_Upsampler=none, but I might have an older inference file)

You shouldn't need to make that change on line 62? If you make a call to inference_gfpgan.py and include the --force_esrgan argument, e.g.:

sudo python3 inference_gfpgan.py -i ./inputs --force_esrgan

Then execution will fall through to the else:, and bg_upsampler will be assigned an instance of RealESRGANer.

jfcarr avatar Mar 15 '22 00:03 jfcarr

That makes sense to me now and you are absolutely 100% correct. I was trying to make it default to use ESRGAN all the time without using an argument. That was especially lazy of me since I usually use a .bin and could just have added it there. Sorry for the confusion.

zarc70 avatar Mar 15 '22 01:03 zarc70

That makes sense to me now and you are absolutely 100% correct. I was trying to make it default to use ESRGAN all the time without using an argument. That was especially lazy of me since I usually use a .bin and could just have added it there. Sorry for the confusion.

No worries! Glad we got it straightened out.

jfcarr avatar Mar 15 '22 02:03 jfcarr

This should be merged

benjaminbrumbaugh avatar May 08 '22 20:05 benjaminbrumbaugh