tdesign-react icon indicating copy to clipboard operation
tdesign-react copied to clipboard

fix(select component): 修复Select组件多选情况下,禁用组件后还能点击删除选项

Open AqingCyan opened this issue 2 years ago • 2 comments

fix #1525

🤔 这个 PR 的性质是?

  • [x] 日常 bug 修复
  • [ ] 新特性提交
  • [ ] 文档改进
  • [ ] 演示代码改进
  • [ ] 组件样式/交互改进
  • [ ] CI/CD 改进
  • [ ] 重构
  • [ ] 代码风格优化
  • [ ] 测试用例
  • [ ] 分支合并
  • [ ] 其他

🔗 相关 Issue

#1525

💡 需求背景和解决方案

在disable 为true的情况下不应该执行多选组件的选项的close逻辑

📝 更新日志

  • fix(Select): 支持多选时,禁用组件,已选选项不能被点击删除

  • [ ] 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

  • [x] 文档已补充或无须补充
  • [x] 代码演示已提供或无须提供
  • [x] TypeScript 定义已补充或无须补充
  • [x] Changelog 已提供或无须提供

AqingCyan avatar Sep 22 '22 12:09 AqingCyan

完成

github-actions[bot] avatar Sep 22 '22 12:09 github-actions[bot]

Codecov Report

Merging #1529 (3fa236e) into develop (8a9ef3a) will increase coverage by 3.75%. The diff coverage is 63.28%.

@@             Coverage Diff             @@
##           develop    #1529      +/-   ##
===========================================
+ Coverage    61.00%   64.75%   +3.75%     
===========================================
  Files         1030     1035       +5     
  Lines        17933    18053     +120     
  Branches      4121     4105      -16     
===========================================
+ Hits         10940    11691     +751     
+ Misses        6993     6362     -631     
Impacted Files Coverage Δ
src/_util/usePluginConfig.ts 0.00% <0.00%> (ø)
src/_util/useRipple.ts 26.38% <0.00%> (-0.38%) :arrow_down:
src/alert/_example/base.jsx 100.00% <ø> (ø)
src/alert/_example/operation.jsx 60.00% <0.00%> (-40.00%) :arrow_down:
src/cascader/_example/check-strictly.jsx 77.77% <ø> (ø)
src/cascader/_example/collapsed.jsx 87.50% <ø> (ø)
src/cascader/_example/disabled.jsx 100.00% <ø> (ø)
src/cascader/_example/filterable.jsx 77.77% <ø> (ø)
src/cascader/_example/keys.jsx 80.00% <ø> (ø)
src/cascader/_example/panel.jsx 80.00% <ø> (ø)
... and 230 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Sep 22 '22 12:09 codecov-commenter