spring-cloud-tencent icon indicating copy to clipboard operation
spring-cloud-tencent copied to clipboard

feature:add @ConditionalOnConfigReflectEnabled annotation

Open lingxiao-wu opened this issue 3 years ago • 2 comments

PR Type

Feature

Describe what this PR does for and how you did.

add @ConditionalOnConfigReflectEnabled annotation

Adding the issue link (#xxx) if possible.

#470

Note

Checklist

  • [x] Add copyright holder at the beginning of .class file if it is new.
  • [x] Add information of this PR to CHANGELOG.md in root of project.
  • [ ] All junit tests passing.
  • [ ] Coverage from Codecov Report should not decrease.

Checklist (Optional)

  • [x] Will Pull Request to branch of 2020.0 and 2021.0.
  • [x] Add documentation in javadoc in code or comment below the PR if necessary.
  • [x] Add your name as @author to the beginning of .class file.

lingxiao-wu avatar Aug 06 '22 01:08 lingxiao-wu

Codecov Report

Merging #496 (3377a7e) into main (a6061e6) will decrease coverage by 0.87%. The diff coverage is 70.37%.

@@             Coverage Diff              @@
##               main     #496      +/-   ##
============================================
- Coverage     72.59%   71.72%   -0.88%     
- Complexity      886      889       +3     
============================================
  Files           173      176       +3     
  Lines          3321     3335      +14     
  Branches        414      413       -1     
============================================
- Hits           2411     2392      -19     
- Misses          693      735      +42     
+ Partials        217      208       -9     
Impacted Files Coverage Δ
...arisRefreshContextPropertySourceAutoRefresher.java 50.00% <50.00%> (ø)
...ter/PolarisReflectPropertySourceAutoRefresher.java 67.56% <67.56%> (ø)
...laris/config/condition/ConfigReflectCondition.java 83.33% <83.33%> (ø)
...polaris/config/PolarisConfigAutoConfiguration.java 88.88% <100.00%> (+1.38%) :arrow_up:
...ig/adapter/PolarisPropertySourceAutoRefresher.java 86.48% <100.00%> (+13.88%) :arrow_up:
...aris/config/spring/property/PlaceholderHelper.java 1.53% <0.00%> (-53.85%) :arrow_down:
...is/config/spring/property/SpringValueRegistry.java 13.51% <0.00%> (-29.73%) :arrow_down:
...config/spring/annotation/SpringValueProcessor.java 30.55% <0.00%> (-16.67%) :arrow_down:
...cent/cloud/polaris/context/ServiceRuleManager.java 43.58% <0.00%> (+5.12%) :arrow_up:
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Aug 06 '22 02:08 codecov-commenter

LGTM.

misselvexu avatar Aug 09 '22 15:08 misselvexu

@lingxiao-wu 方便也提交到2020和2021分支吗?

SkyeBeFreeman avatar Aug 24 '22 07:08 SkyeBeFreeman

@lingxiao-wu 方便也提交到2020和2021分支吗?

最近在酒店隔离没带电脑,你先合并一下吧嘿嘿🤤🤤🤤

lingxiao-wu avatar Aug 24 '22 07:08 lingxiao-wu

@lingxiao-wu 方便也提交到2020和2021分支吗?

最近在酒店隔离没带电脑,你先合并一下吧嘿嘿🤤🤤🤤

好,我晚点直接cherry-pick一下

SkyeBeFreeman avatar Aug 24 '22 07:08 SkyeBeFreeman