rapidjson icon indicating copy to clipboard operation
rapidjson copied to clipboard

fix: delete validator before clear

Open junwha opened this issue 2 years ago • 2 comments

Hi, we found an incorrect use of Clear API of the allocator, which leads to Use-After-Free in schematest.

At test/perftest/schematest.cpp:208, the validator is constructed with validatorAllocator, and the chunks allocated during line 210 to line 213 are collected by the Clear API at line 214 as the for statement is ended. However, the destructor of GeneriSchemaValidator is called at line 215, leading to invalid accesses to the chunks(Stack).

To avoid this issue, I added explicit delete to the validator before the Clear API call.

Thank you very much for taking the time to revise this issue!

junwha avatar Dec 25 '23 11:12 junwha

I think may just add a block {} to force destructing the validator first.

miloyip avatar Dec 26 '23 10:12 miloyip

Hi @miloyip, Thank you for the feedback! I changed the patch as you commented.

junwha avatar Dec 26 '23 12:12 junwha