rapidjson
rapidjson copied to clipboard
[WIP] Prevent the constructor from being called multiple times
As @hkarel pointed out in #2033, the current implementation of GenericValue::operator[]()
calls GenericValue::GenericValue()
multiple times when there's no such a member. There's no real issue with that, but it's not ideal. This PR tries to prevent the constructor from being called multiple times.
Note: As I mentioned in #2033, I found some fundamental issues. I will work on it within a few days when I have free time.
Hello, @jaepil ! Do you have any progress on this PR? When do you plan to include these improvements in the Tencent/rapidjson repo?
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.
:x: Jaepil Jeong
:x: jaepil
Jaepil Jeong seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.