rapidjson icon indicating copy to clipboard operation
rapidjson copied to clipboard

Remove CMakeLists.txt from NAMES in FIND_PATH call

Open vsui opened this issue 5 years ago • 2 comments

FIND_PATH will search for satisfying directories in $PATH before any of the PATHS variables (i.e. ${GTEST_SEARCH_PATH}) [1]. So if you have any directory in your $PATH that contains a CMakeLists.txt it will be the result.

I ran into this issue when trying to build with the vendored gtest, since I had an unrelated directory in my $PATH that contained a CMakeLists.txt.

[1] https://cmake.org/cmake/help/v3.17/command/find_path.html

vsui avatar Jun 07 '20 22:06 vsui

CLA assistant check
All committers have signed the CLA.

tencent-adm avatar Jun 07 '20 22:06 tencent-adm

Coverage Status

Coverage increased (+0.1%) to 99.879% when pulling 1ce1b6afff2e3f6c4f901b2ae23e35e27fd4c5fc on vsui:master into 1a803826f1197b5e30703afe4b9c0e7dd48074f5 on Tencent:master.

coveralls avatar Jun 07 '20 23:06 coveralls