Tencent
Unattributed / stolen code in PR
I've been alerted that the following merged PR https://github.com/Tencent/HunyuanDiT/pull/59 seems to take large large parts of code from the following ComfyUI custom node with no attribution to me or chaojie who created the initial draft implementation in the ExtraModels repository. The apache2 license for the ComfyUI related parts of the code is also not preserved/present.
There also seems to be a number of odd design choices due to the copypaste nature of the code, such as the dtype being cast twice after model creation instead of once like in the original repo
The original PR also briefly used the node name "DiTCheckpointLoader", which would have conflicted with a node already present in the original repository meant for loading the original DiT models from facebook/meta, probably another error during copying.
There are numerous other examples, such as this comment that I added about the performance impacts of my design choice being now part of this file here with no added context.
I'm not sure what the best solution is. The PR in question clearly goes against the principles of open source, and is not transformative in nature.
Tagging @wpdong0727 though it looks like the account doesn't have any other commits/activity.
our code based on https://github.com/Tencent/HunyuanDiT/pull/59, this PR seems did't refer your work. I can contact this PR author and talk about this issue.
this PR seems did't refer your work
Please double check the linked references and comments. Almost all ComfyUI-specific parts in that PR are 1:1 copied including the comments.
Original commit added on May 20th
Dear city96, we have verified that many of the files in that PR indeed use the functions you wrote. Could we add your GitHub project to the reference section in the next version? We were not aware that he referenced your work before merging this PR, and he did not inform us either. We are very sorry.
Dear city96, we have verified that many of the files in that PR indeed use the functions you wrote. Could we add your GitHub project to the reference section in the next version? We were not aware that he referenced your work before merging this PR, and he did not inform us either. We are very sorry.
Thank you for getting back to me on this. Adding a reference in the readme or even just a file header to the relevant file(s) is perfectly fine, and I have nothing against the code from my repo being used in that way. It's open source, after all - the main issue was just the lack of attribution in that original PR and some of the odd design choices presented in it.
So yes, feel free to close this issue once that is added :)