feat(android): add nested scroll support for ListView and ScrollView
Pre-PR Checklist
- [x] I added/updated relevant documentation.
- [x] I followed the Convention Commit guideline with maximum 72 characters to submit commit message.
- [x] I squashed the repeated code commits.
- [x] I signed the [CLA].
- [x] I added/updated test cases to check the change I am making.
- [x] All existing and new tests are passing.
π Thanks for your contributing!
Our collaborators will review your pull request after all status checks have been passed.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.
Codecov Report
Merging #2448 (4156b0d) into master (9e7fb70) will increase coverage by
10.25%. The diff coverage isn/a.
:exclamation: Current head 4156b0d differs from pull request most recent head 871a7df. Consider uploading reports for the commit 871a7df to get more accurate results
@@ Coverage Diff @@
## master #2448 +/- ##
===========================================
+ Coverage 62.36% 72.61% +10.25%
===========================================
Files 30 67 +37
Lines 1990 4463 +2473
Branches 0 550 +550
===========================================
+ Hits 1241 3241 +2000
- Misses 749 1173 +424
- Partials 0 49 +49
| Impacted Files | Coverage Ξ | |
|---|---|---|
| packages/hippy-vue/src/renderer/list-node.js | 0.00% <0.00%> (-53.85%) |
:arrow_down: |
| packages/hippy-vue/src/util/node.js | 58.62% <0.00%> (-26.38%) |
:arrow_down: |
| packages/hippy-vue/src/runtime/node-ops.js | 83.87% <0.00%> (-10.25%) |
:arrow_down: |
| packages/hippy-vue/src/renderer/native/index.js | 81.42% <0.00%> (-3.78%) |
:arrow_down: |
| ...ppy-vue/src/renderer/native/style/css-selectors.js | 34.63% <0.00%> (-3.45%) |
:arrow_down: |
| packages/hippy-vue/src/renderer/element-node.js | 81.43% <0.00%> (-2.38%) |
:arrow_down: |
| packages/hippy-vue/src/util/index.js | 65.82% <0.00%> (-0.85%) |
:arrow_down: |
| packages/hippy-vue/src/runtime/native.js | 39.13% <0.00%> (-0.16%) |
:arrow_down: |
| packages/hippy-vue/src/runtime/netInfo.js | 78.94% <0.00%> (ΓΈ) |
|
| packages/hippy-vue/src/elements/built-in.js | 91.78% <0.00%> (ΓΈ) |
|
| ... and 46 more |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.
:white_check_mark: iPel
:x: HOHOHOTangoDown
You have signed the CLA already but the status is still pending? Let us recheck it.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.
After a quick scan, I have approved workflows to run.