Thomas B

Closes #81

`WriteOperation` (atomic write operations) is currently not usable because there's no way to construct it. In addition, the method `rados_commit_write_operations` takes `&mut WriteOperation`, but re-using a `WriteOperation` that has succeeded...

Fixes #84

To reproduce: - Create a `Rados` by connecting - Create an `IoCtx` with `rados.get_rados_ioctx(pool_name)` - Drop the `Rados` - Use the `IoCtx` -> segfaults => API is [unsound](https://doc.rust-lang.org/nomicon/working-with-unsafe.html). `rados.get_rados_ioctx(pool_name)` should...

Remove unnecessary `pub`

1

(non backwards-compatible) Alternately we could make this return an explicit type so that it's expressable, but I doubt that would actually be necessary for anyone. https://github.com/scylladb/scylla-rust-driver/blob/db8d52893bdef56977872a09f51fda2fa423168f/scylla-cql/src/frame/value.rs#L189

**Describe the bug** In semgrep's Rust matching, `match` matching ignores the branches enum variant names **To Reproduce** https://semgrep.dev/playground/s/ZqJ1W ```yml rules: - id: my_pattern_id languages: - rust severity: ERROR message: Semgrep...

Lot of unsafe code could probably be replaced by safe code without perf. impact

5

Looking at the source code: https://docs.rs/slice-group-by/0.2.6/src/slice_group_by/linear_group/linear_group_by.rs.html#131-136 It seems this crate makes extensive use of `unsafe`. However, it also looks like this `unsafe` is unnecessary as it creates no performance improvement:...

LinearGroupByKey could allow provided closure to borrow from input

2

Current: ```rust fn linear_group_by_key(&self, func: F) -> LinearGroupByKey where F: FnMut(&T) -> K, K: PartialEq ``` Does not allow: ```rust let strings = vec!["A".to_owned()]; strings.linear_group_by_key(|s| s.as_str()); ``` In order for...

Option<Vec> support

3

It would be nice to have a way to make it work with Option as well, either via `serde_with`'s `serde_as` framework, or via a dedicated function