Thomas B

Results 275 comments of Thomas B
trafficstars

I still have this issue on the current latest `graphql_client` (0.9) :(.

Currently, using the rust normalization feature, fields of type `ID` get normalized to `Id` and can't resolve. That makes it annoying to use.

Hmmm this seems to work (thanks a lot!), but that is clearly not what I understand from the `USAGE` section: `graphql-client introspect-schema [OPTIONS] ` with `[OPTIONS]` as a placeholder for...

This does not pass CI though

There's the same kind of suboptimal writing in the serde module, e.g. it uses visit_str instead of visit_borrowed_str. Looks like this (and possibly other issues) should be ported over to...

> While it would be nice to ensure that a type has all the necessary fields, I'm not sure there is a feasible way to do this for all the...

TL;DR - Jump to *As a conclusion* below. The fact that all the fields are optional in protocol buffers is indeed by design of the protocol buffers : it enables...

> rust-protobuf can have an option to skip generation of unknown_fields field. Great! What are the next steps ? :) (Note that we are somewhat busy at the moment and...

https://github.com/diesel-rs/diesel/pull/2935/files#diff-96f0313427dbd2be25856359744270243ad151bb486851aa18bff4eeac6ba1fcR327 has gotten this particular issue worse: because the serialization failure may happen on commit attempt, in order to retry on serialization failures we've currently got to write this: ```rust...

> @Ten0 We could probably do something to what we do [here](https://github.com/diesel-rs/diesel/blob/c237a74b63900b734c659a201fc1d6b87108033b/diesel/src/connection/transaction_manager.rs#L313-L325) for `RollbackError`? That would mean we return `SerializationFailure` directly and everything else wrapped into a `CommitTransactionFailed` error? I'm...