Thomas B

Results 326 comments of Thomas B

> maybe we could deprecate it and replace it with from_tcp and from_tcp_unchecked where the first method sets is as non-blocking and checks that it's actually a tcp stream. This...

I'm not sure what you mean by "checks that it's actually a tcp stream" though: the entry type is [`TcpListener`](https://doc.rust-lang.org/stable/std/net/struct.TcpListener.html) so AFAICT that in particular is already guaranteed by typing,...

That seems to be checking that the file is a [fifo](https://man7.org/linux/man-pages/man7/fifo.7.html), which seems to not be guaranteed by typing there. (Just to make sure it wasn't missed: Should I open...

Hello! IIRC the draft PR is pending an answer to point 4 of [this comment](https://github.com/tokio-rs/tokio/pull/5597#issuecomment-1666935632) as well as to [this comment](https://github.com/tokio-rs/tokio/pull/5597#issuecomment-1673681155).

That is worrisome for next stable versions... So you can connect and edit, just not install extensions?

No sorry I have not been able to dedicate time to this, still same workaround as above, help welcome.

It's unclear what would have to be done, one needs to investigate the links provided in https://github.com/nix-community/nixos-vscode-server/issues/90#issuecomment-2891510435.

> VS Code Version: 1.93.1 This seems like a relatively old version. Are you sure that's the correct version number, and if so, have you tried removing the .vscode-server folder,...

It might be that it stores lts data in another folder than .vscode-server, in which case that has to be specified in the corresponding option of the module IIRC, and...

That's the error you get from not patching. The path is in the error: `$HOME/.cursor-server`