Thomas B

One more clippy lint I don't agree with -.- Type seems clear enough and I feel like adding a new one would instead increase overall complexity. Fine if I silence...

> For instance, consider a situation when an enforced node is removed from the cluster. Not only will the correct shard not be targeted If the node is removed from...

> As I imagine it, one would once (upon application initialisation) consistute/associate a batch with a specific shard No, rather I have an app that receives millions of lines per...

> Are the lines that you get every second merely bind values to be sent with prepared statements with fixed query string? Basically yes. There's a bunch of different prepared...

> Have you tested your solution? How? Could you write some unit tests? > Maybe you could write an example I have added an test that may also serve as...

I guess that would simplify the code. 🙂👍

> This way we would avoid merging this and then throwing away with the refactor introduced. Hmm AFAICT this is the only line that would change: https://github.com/Ten0/scylla-rust-driver/blob/59ced8f72420c0b2dae61f18ff83b969f7cdf2d7/scylla/src/transport/session.rs#L1934-L1936 (besides the signatures...

I don't see why it wouldn't be relevant. I may work on this still if there's a change at getting it merged.

Workflows run would help :) (not sure what is currently using this and should be tested)

@microsoft-github-policy-service agree