stitches-native icon indicating copy to clipboard operation
stitches-native copied to clipboard

Fix: compound variants don't work when each variant is determined by media

Open tkow opened this issue 2 years ago • 3 comments

Fix #39, #41

スクリーンショット 2022-11-16 16 37 47

tkow avatar Nov 16 '22 09:11 tkow

@Temzasse Could you have time to check this PR? This implements,

  1. Styles merge functionality ordered by these lines.
  2. Media styles extract finally matched value and explicitly process in same manner.
  3. Make latter conflict multiple match variants and styles prioritized.
  4. Fix compound variants works when they matches default values and media select variants.
<Component color={'@bp': { purple: true } underline={true} />

or

css({
  defaultVarinats: {
    color: 'purple'
  }
})
<Component underline={true} />

don't match purple==true && underline == true before. 5. Fix boolean flag media (https://github.com/Temzasse/stitches-native/issues/39)

tkow avatar Nov 30 '22 11:11 tkow

@tkow sorry for taking so long to review this. Would you mind rebasing this with the latest main? I will try to take a look at this during this week 🙂

Temzasse avatar Dec 07 '22 16:12 Temzasse

@Temzasse Don't worry, I don't care when it's done. Have a good and relax vacation! I have no doubt and wonder most people in the world drives enthusiastic by World Cup makes me no choice to work. I rebased from current latest branch and please check, If you feel like it.

tkow avatar Dec 09 '22 19:12 tkow