react-modal-sheet icon indicating copy to clipboard operation
react-modal-sheet copied to clipboard

initialSnap -34px bug

Open 0oooooooo0 opened this issue 2 years ago • 4 comments

<Sheet snapPoints={[1, 0.7, 0]} initialSnap={1}>

will not open by 0.7, but will open with a value of -34px.

0oooooooo0 avatar Nov 16 '23 03:11 0oooooooo0

I'm having a similar problem : when the sheet is rendered with open=true, it starts from the top, then slides back to the initialSnap.

Looks like a bug to me : it should slide from the bottom.

Note that this works with a default open=false and then a dynamic setOpen(true).

Here is a sandbox to demonstrate this behaviour : https://codesandbox.io/p/devbox/test-react-modal-sheet-x56rff?file=%2Fapp%2FSnapPoints.tsx%3A15%2C48

Note that it is easily fixed with these three lines :

	useEffect(() => {
		setTimeout(() => setOpen(true), 1)
	}, [setOpen])

@0oooooooo0 Is it related to your bug ? If not, I'll raise a new issue :)

laem avatar Dec 11 '23 09:12 laem

This looks like the same issue. Check out my PR

https://github.com/Temzasse/react-modal-sheet/pull/148

0oooooooo0 avatar Dec 12 '23 15:12 0oooooooo0